Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(staging): update staging task definitions, and expose pprof server #2305

Merged
merged 2 commits into from
Feb 18, 2022
Merged

chore(staging): update staging task definitions, and expose pprof server #2305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f86b47
update staging task definitions, update dd agent confd included metrics
timwu20 Feb 16, 2022
edf921c
update mem sizes
timwu20 Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/staging/kusama-taskdef.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
{
"containerPort": 8540,
"protocol": "tcp"
},
{
"containerPort": 6060,
"protocol": "tcp"
}
],
"environment": [],
Expand All @@ -35,7 +39,7 @@
"expression": "attribute:ecs.availability-zone==us-east-2a"
}
],
"memory": "16041",
"memory": "12288",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Shouldn't we leave it as 16GB until the memory usage is not bubbling anymore?

As in the 'human cost' of developers from changing it down to 12GB is probably larger than paying for 4GB extra right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole instance would die if we used every available MB. Since substrate only uses 6-10GB, I thought 12GB was a good compromise for now.

"family": "gossamer-kusama",
"networkMode": "host",
"requiresCompatibilities": [
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/staging/openmetrics.d/kusama-conf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,7 @@ instances:
#
metrics:
- gossamer_*
- network_*
- service_*
- system_*
- go_*

## @param prometheus_metrics_prefix - string - optional
## Removes a given <PREFIX> from exposed Prometheus metrics.
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/staging/openmetrics.d/polkadot-conf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,7 @@ instances:
#
metrics:
- gossamer_*
- network_*
- service_*
- system_*
- go_*

## @param prometheus_metrics_prefix - string - optional
## Removes a given <PREFIX> from exposed Prometheus metrics.
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/staging/polkadot-taskdef.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
{
"containerPort": 8540,
"protocol": "tcp"
},
{
"containerPort": 6060,
"protocol": "tcp"
}
],
"environment": [],
Expand All @@ -35,7 +39,7 @@
"expression": "attribute:ecs.availability-zone==us-east-2a"
}
],
"memory": "16041",
"memory": "12288",
"family": "gossamer-polkadot",
"networkMode": "host",
"requiresCompatibilities": [
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.staging
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ RUN go get ./...
RUN go build github.com/ChainSafe/gossamer/cmd/gossamer

RUN ["sh", "-c", "gossamer init --chain=${chain}"]
ENTRYPOINT ["sh", "-c", "service datadog-agent restart && gossamer --chain=${chain} --basepath=${basepath}/${chain} --publish-metrics"]
EXPOSE 7001 8546 8540 9876
ENTRYPOINT ["sh", "-c", "service datadog-agent restart && gossamer --chain=${chain} --basepath=${basepath}/${chain} --publish-metrics --pprofserver --pprofaddress=\":6060\""]
EXPOSE 7001 8546 8540 9876 6060
4 changes: 1 addition & 3 deletions devnet/cmd/update-dd-agent-confd/confd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,7 @@ instances:
#
metrics:
- gossamer_*
- network_*
- service_*
- system_*
- go_*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these removed namespaces all refactored to be within gossamer_* now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are all under go_* now.


## @param prometheus_metrics_prefix - string - optional
## Removes a given <PREFIX> from exposed Prometheus metrics.
Expand Down