chore(staging): update staging task definitions, and expose pprof server #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwu20
requested review from
noot,
edwardmack,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya and
qdm12
as code owners
qdm12
approved these changes
Feb 17, 2022
| - network_* | ||
| - service_* | ||
| - system_* | ||
| - go_* |
There was a problem hiding this comment.
Are these removed namespaces all refactored to be within gossamer_* now?
There was a problem hiding this comment.
They are all under go_* now.
| @@ -35,7 +39,7 @@ | |||
| "expression": "attribute:ecs.availability-zone==us-east-2a" | |||
| } | |||
| ], | |||
| "memory": "16041", | |||
| "memory": "12288", | |||
There was a problem hiding this comment.
Why? Shouldn't we leave it as 16GB until the memory usage is not bubbling anymore?
As in the 'human cost' of developers from changing it down to 12GB is probably larger than paying for 4GB extra right?
There was a problem hiding this comment.
The whole instance would die if we used every available MB. Since substrate only uses 6-10GB, I thought 12GB was a good compromise for now.
kishansagathiya
approved these changes
Feb 18, 2022
timwu20
force-pushed
the
tim/staging-updates
branch
from
f1fa6c1
to
edf921c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Issues
Primary Reviewer