EXT_feature_metadata feedback #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2021
|
@donmccurdy the spec went through a few iterations, first in #1, and then two revisions in the current branch. One thing we plan to do soon is remove the landing page and move the change log to a separate section in the document like OpenGL extensions.
I might do this reorg now so it's easier to review. |
|
@donmccurdy all set now 🙂 |
donmccurdy
reviewed
Aug 31, 2021
donmccurdy
reviewed
Sep 1, 2021
donmccurdy
reviewed
Sep 1, 2021
donmccurdy
reviewed
Sep 1, 2021
donmccurdy
reviewed
Sep 1, 2021
donmccurdy
reviewed
Sep 3, 2021
There was a problem hiding this comment.
Still thinking a bit about parallelism in ID textures and ID attributes, but adding a couple followup thoughts on feature textures. Resolved in #14.
…feature indicators.
…s/propertyTextures
Rename EXT_feature_metadata → EXT_mesh_features
… on feature tables and textures.
EXT_feature_metadata: Restrictions on string IDs, add property table and texture names
Restore EXT_feature_metadata alongside EXT_mesh_features
Consolidate staging branches
Update EXT_mesh_features changelog
|
I think my remaining feedback on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4 for @pjcozzi's feedback and see #3 for the original PR.
Direct link to extension: https://github.com/CesiumGS/glTF/tree/3d-tiles-next/extensions/2.0/Vendor/EXT_feature_metadata