Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CzmlDataSource updates #4023

Merged
merged 5 commits into from
Jun 16, 2016
Merged

CzmlDataSource updates #4023

merged 5 commits into from
Jun 16, 2016

Conversation

shunter
Copy link
Contributor

@shunter shunter commented Jun 15, 2016

  • I added some missing Ellipsoid properties which were left out of Refactor DynamicScene to use Geometry & Appearances #1444
  • I reordered the lines that process each CZML property to be relatively consistent, and to match the order of properties in the CZML schema. Loosely, I put them in the order:
    • show
    • fundamental/required properties (e.g. "image" or "text")
    • other definitional-type properties
    • fill & fill material
    • outline, outline material, outline width
    • other esoteric features

More changes to come in future PRs.

@mramato
Copy link
Contributor

mramato commented Jun 16, 2016

Thanks @shunter

@mramato mramato merged commit fd35ce7 into master Jun 16, 2016
@mramato mramato deleted the czmlDataSourceUpdates branch June 16, 2016 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants