Added simple shadows sandcastle #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var scene = viewer.scene; | ||
| var shadowMap = scene.shadowMap; | ||
| shadowMap._maxmimumDistance = 10000.0; | ||
| scene.globe.castShadows = true; |
There was a problem hiding this comment.
globe is also available off of viewer.
|
Take a screenshot for this for the Sandcastle gallery. |
|
lilleyse
force-pushed
the
shadows-simple-sandcastle
branch
from
7adfbc5
to
38821b7
Compare
lilleyse
force-pushed
the
shadows-simple-sandcastle
branch
from
39bc370
to
a93f019
Compare
|
Updated. |
|
When I switch the view from Exton to Half Dome, the aircraft stops animating. Is that intentional? |
No... I'll look into that. |
|
Otherwise, this is great. Let me know when to merge. |
|
Even with a maximumed browser window, I'm getting run in with the standard toolbar:
|
|
This should be ready now. I vertically aligned the buttons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2594
The simple sandcastle demo for shadows. There are a few places where I access scene directly, which I shouldn't do for a Showcase demo. I can maybe make these accessible through
Viewerinstead.