Billboard and Label tweaks #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjcozzi please review this before looking at |
| @@ -1004,6 +1013,8 @@ define([ | |||
| boundingVolume.radius += size + offset; | |||
| } | |||
|
|
|||
| var writers = []; | |||
There was a problem hiding this comment.
Sorry to bother with local variable names, but can we include scratch in this like we do everywhere else?
|
Wow, thanks for cleaning up all those tests.
:) |
|
This is ready. |
This was referenced Apr 29, 2015
emackey
added a commit
that referenced
this pull request
Apr 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls out some feedback from the point-primitive branch (#2632) that was applicable to Billboards and Labels.