Fix EllipseOutlineGeometry and CircleOutlineGeometry packing #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`extrudedHeight` was getting defaulted to `0` during the pack/unpack process, which caused asynchronous geometry to be extruded when it should have just been at height. Fixes #2499
|
Looks good, thanks. |
pjcozzi
added a commit
that referenced
this pull request
Mar 1, 2015
…ometry Fix EllipseOutlineGeometry and CircleOutlineGeometry packing
mramato
added a commit
that referenced
this pull request
Mar 1, 2015
While working on #2526, I found the same problem with RectangleOutline. I checked Polygon and Corridor, and they both work as expected, so I think this is the last of this particular type of issue.
|
Thank you @mramato. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extrudedHeightwas getting defaulted to0during the pack/unpack process, which caused asynchronous geometry to be extruded when it should have just been at height.Fixes #2499
This is for 1.7