PolylineGeometry IDL split #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nging the triangle split code to catch that case.
| // and intersects the xz-plane | ||
| var intersection = IntersectionTests.lineSegmentPlane(p0, p1, xzPlane); | ||
| if (defined(intersection)) { | ||
| // move point on the xz-plane slightly away from the plane |
There was a problem hiding this comment.
Why is this needed? Because of noise in the cartographic conversion function?
There was a problem hiding this comment.
Yes. If we set the y component to zero, we sometimes get lines that draw over the whole map to the other side of the IDL.
|
Update README.md |
|
Does this need new unit tests? |
…s the IDL. Custom geometries will still be split based on the primitive type.
|
@pjcozzi This is ready for another look. |
|
Update this test. |
| var newIndices = []; | ||
|
|
||
| var length = newPositions.length / 3; | ||
| for (var i = 0; i < length; i += 4) { |
There was a problem hiding this comment.
Can't we do a quick check of the bounding volume before entering this loop?
There was a problem hiding this comment.
We check the bounding sphere in wrapLongitude before the code for splitting triangles, lines or polylines.
|
@pjcozzi This is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1197.
PolylinePipeline.wrapLongitudeandGeometryPipeline.wrapLongitudewere both being called when creating and batchingPolylineGeometry. So in 2D, the line would be split by the IDL and then the triangles would be tested for intersection. In 3D, the line would still be split by the IDL in the first function and the second function would not be called.This removes the
PolylinePipeline.wrapLongitudecall and adds a special case toGeometryPipeline.wrapLongitudeforPolylineGeometrys. A special case is needed because the polyline triangles are degenerate (to lines) that are expanded in the vertex shader.