[DRAFT] Additional Tests for the Preprints index page #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
requested changes
Aug 15, 2023
|
|
||
| // And the lead yield is verified | ||
| // eslint-disable-next-line max-len | ||
| assert.dom(this.element.querySelector('[data-test-lead-yield]')).hasText('This is the lead', 'The lead in yielded correctly'); |
There was a problem hiding this comment.
Suggested change
| assert.dom(this.element.querySelector('[data-test-lead-yield]')).hasText('This is the lead', 'The lead in yielded correctly'); | |
| assert.dom(this.element.querySelector('[data-test-lead-yield]')).hasText('This is the lead', 'The lead is yielded correctly'); |
|
|
||
| // And the row yield is verified | ||
| // eslint-disable-next-line max-len | ||
| assert.dom(this.element.querySelector('[data-test-row-yield]')).hasText('This is the row', 'The lead in yielded correctly'); |
There was a problem hiding this comment.
Suggested change
| assert.dom(this.element.querySelector('[data-test-row-yield]')).hasText('This is the row', 'The lead in yielded correctly'); | |
| assert.dom(this.element.querySelector('[data-test-row-yield]')).hasText('This is the row', 'The row is yielded correctly'); |
| @@ -23,7 +22,6 @@ export default class BrandedHeader extends Component<InputArgs> { | |||
| @requiredAction onSearch!: (value: string) => void; | |||
| @tracked showingHelp = false; | |||
|
|
|||
| providerModel?: ProviderModel; | |||
There was a problem hiding this comment.
This doesn't seem related to adding new tests. This would have been a good addition to the "Changes" section of the PR, to let reviewers know that this is expected and what's going on here. Do you not have a providerModel any more?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add additional tests to the preprints index page
Summary of Changes
Add additional tests to the preprints index page
Screenshot(s)
N/A
Side Effects
Better deployment
QA Notes
N/A