Feature/Preprints Content Page - Mobile View [PREP-201] #224
Conversation
…s on sm screen, relying on color to differentiate it.
pattisdr
changed the title
pattisdr
force-pushed
the
feature/preprints-mobile-view
branch
from
d259d7a
to
21364d4
Compare
…izontal or vertical scroll.
…cate file titles.
|
@icereval, so this is the PR you want me to upgrade ember-resolver dependency? |
|
I think it's just "whichever PR fixes the last places where it's wrong". |
…er-preprints into feature/preprints-mobile-view
|
@brianjgeiger is correct, if we can just wrap in @binoculars couple changes I think we'll be g2g and avoid the depreciation. |
There was a problem hiding this comment.
The mobile page looks much better now. No changes requested for that.
Thanks @pattisdr for updating the helpers to kebab-case. Let's keep the ember-resolver version pinned at 2.1.0 for now since it works with both kebab-case and camel-case. After yarn goes through, we can update it to the latest version (2.1.1 as of now) as the other packages). This is due to the fact that the yarn.lock file will need to be updated and committed. I'll put in another ticket just to update the dependencies and resolve any issues that occur as a result of the updates.
The ember-osf vesion is also causing a merge conflict, so just need to update that.
| "ember-page-title": "3.0.6", | ||
| "ember-power-select": "1.0.0-beta.7", | ||
| "ember-read-more": "0.0.13", | ||
| "ember-resolver": "2.1.0", | ||
| "ember-resolver": "^2.0.3", |
There was a problem hiding this comment.
Let's leave this pinned at 2.1.0 for now, at least until yarn goes through, to avoid merge conflicts.
…er-preprints into feature/preprints-mobile-view # Conflicts: # package.json
Ticket
https://openscience.atlassian.net/browse/PREP-201
Purpose
Fixes several mobile-view issues on the preprints content page.
Changes
Edit button/logo were cut off on mobile view - removes logo entirely and moves edit button down to next row. Centers all text in header (title, contributors, dates, edit button).
"Download preprint" and version display were overtop of other data - moves to new line.
Distinguish "Primary" file differently in mobile view - different layout for supplementary file browser - mobile view