shell script changes for POSIX compliance and portability #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the use of bash-isms and simplifies some of the shell syntax constructs. I use ShellCheck as well to validate my changes. The resulting script runs under bash, but also shells like dash and zsh.
msrb
reviewed
Mar 27, 2020
|
|
||
| # This container builds with koji into $RPMDIR starting from a pagure PR | ||
|
|
||
| set -xeo pipefail |
There was a problem hiding this comment.
Was this removal intentional?
There was a problem hiding this comment.
Yes, that line is not portable shell.
|
[test] |
|
@dcantrell the stage trigger CI job fails with: Do you think it is related to your changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a batch of shell scripts I modified to work with a wider range of shells. Past experience has shown me that bash versions can vary from time to time. I made changes and then ran these through shellcheck as well.
If these are not of interest, let me know. Otherwise I will continue making changes to the other scripts I find in the tree.