Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit testing to jenkins containers #89

Merged
merged 2 commits into from
Oct 11, 2018

Conversation

dirgim
Copy link
Collaborator

@dirgim dirgim commented Sep 24, 2018

This change limits contra-env-setup CI tests to only build and test for jenkins master and slave containers.

This prevents errors stemming from changes to the contra-env-sample-project (which will have its own CI for testing all the included containers) from blocking the contra-env-setup CI.

Also, now the test_jenkins_running test retries getting the jenkins login page in case the service didn't start up in time for the test run.

@arilivigni
Copy link
Member

@dirgim as part of moving the infrastructure out I think the helper containers linchpin and ansible also need to be validated at least for building. Can we also include them as well as the metrics ones as we want to make sure our core infrastructure builds as expected as we discussed a couple of weeks ago.

@dirgim
Copy link
Collaborator Author

dirgim commented Sep 24, 2018

@arilivigni I agree, I opened a card to have a separate CI for contra-env-sample-project which would test the building of every container we have there and would trigger on PRs to that repo. My idea is to separate the testing of contra-env-sample-project and testing of contra-env-setup into two distinct CI pipelines.

@arilivigni
Copy link
Member

@dirgim sample project would not container infrastructure like Jenkins master/slave, helper containers ansible-executor and linchpin-executor, metrics containers which would be in a new repo called contra-infra. The sample project would contains H-DSL example, Jenkinsfile sample pipelines, and maybe a sample shared library. I updated the document we had a meeting about please take a look and make comments.

@dirgim dirgim changed the title Limit testing to jenkins containers WIP: Limit testing to jenkins containers Sep 25, 2018
@dirgim
Copy link
Collaborator Author

dirgim commented Sep 25, 2018

@arilivigni I'll modify this PR so it follows the new structure of the project after we migrate it, but I think the general idea stays the same.

@arilivigni
Copy link
Member

@dirgim as long as the helper and metrics containers are included now I am fine with that, but they should be done regardless of the restructure since this is our infra.

@dirgim dirgim changed the title WIP: Limit testing to jenkins containers Limit testing to jenkins containers Oct 11, 2018
@dirgim
Copy link
Collaborator Author

dirgim commented Oct 11, 2018

@arilivigni I tested the change, everything looks ok and the test time has been almost halved.

Copy link
Member

@arilivigni arilivigni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sorry forgot to give final approval

@dirgim dirgim merged commit 3ed25ca into CentOS-PaaS-SIG:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants