Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template blacklist and whitelist #87

Merged

Conversation

dirgim
Copy link
Collaborator

@dirgim dirgim commented Sep 17, 2018

This change adds os_template_whitelist and os_template_blacklist group variables (lists) that define which templates will be included/skipped according to these rules:

  • All the template names in os_template_blacklist will be skipped
  • If os_template_whitelist is defined, only the template names listed in it will be built
  • If a template name shows up in both os_template_whitelist and os_template_blacklist, it will be skipped, as the blacklist takes precedence

Both lists are empty by default, meaning that all the templates in the os_template_dir will be built.

@johnbieren
Copy link

[test]

@joejstuart
Copy link
Contributor

Is there an easy way to see what templates can be built?

@dirgim
Copy link
Collaborator Author

dirgim commented Sep 17, 2018

@joejstuart it uses the template name stated in the yaml, so some advanced grepping might help.
Or maybe using the oc process -f {{ template_file.path }} | jq '.items[1].metadata.labels.template' command on each file.

@dirgim
Copy link
Collaborator Author

dirgim commented Sep 17, 2018

[test]

@joejstuart
Copy link
Contributor

@dirgim Sounds good. Thanks for the explanation.

Copy link
Member

@arilivigni arilivigni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@psiroky psiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arilivigni arilivigni merged commit a3a6e67 into CentOS-PaaS-SIG:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants