Add fedora28 testing container, run container tests in parallel #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the fedora28 testing container to the contra-env-setup CI. The container contains a fix for a libvirt bug that occurs when first starting the minishift VM, running fix-minishift.sh resolves the issue. Jenkinsfile has been updated to run tests on both centos7 and fedora28 in parallel. JUnit archiving has been added, and the test logs have corresponding prefixes for each container. ed: test/config/Dockerfiles/contra-env-setup-test-c7/prepare_and_test.sh
arilivigni
approved these changes
Sep 12, 2018
There was a problem hiding this comment.
LGTM
One question is there logic specific about the containers that are currently in the sample project. Does this need to be more general? Is it only for key services like Jenkins? Will we need something specific for the influxdb and grafana or the next things?
|
Currently it's just (as much as it's possible) generically checking for the jenkins master and slave because that's expected to be included in every use case. I would include any specific tests into a separate CI pipeline that's testing the sample project specifically. |
|
[merge] |
|
Yeah, I'll have to add a merge job with image rebuilds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the fedora28 testing container to the contra-env-setup CI.
The container contains a fix for a libvirt bug that occurs when first starting the minishift VM, running fix-minishift.sh in the pipeline resolves the issue.
Jenkinsfile has been updated to run tests on both centos7 and fedora28 in parallel.
JUnit archiving has been added, and the test logs have corresponding prefixes for each container.