Make sure configured minishift profile is active #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before setting the configration options, like skip-check-openshift-version, the configured profile needs to be active. Before this change, the config options were applied to whatever profile was configured as active, before the contra-env-setup got executed.
arilivigni
reviewed
Sep 5, 2018
| @@ -46,8 +49,7 @@ | |||
| dest: "{{ minishift_dest_dir }}/minishift.iso" | |||
| timeout: 120 | |||
|
|
|||
| # Check if the minishift profile exists | |||
| - name: "Check if the minishift profile exists" | |||
| - name: "Check if the minishift profile is running" | |||
There was a problem hiding this comment.
We don't need to also check if the profile exists or by setting it active we accomplish that?
There was a problem hiding this comment.
Yes, by activating the profile, we also make sure that it exists (minishift profile set <name> will create the profile if it does not exist).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before setting the configration options, like
skip-check-openshift-version, the configured profile needs to be active.
Before this change, the config options were applied to whatever profile
was configured as active, before the contra-env-setup got executed.