Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the case where project does not contain a display name #73

Merged
merged 2 commits into from
Aug 31, 2018

Conversation

scoheb
Copy link
Member

@scoheb scoheb commented Aug 31, 2018

  • the check for an existing project fails if project
    does not contain a description

Copy link
Member

@arilivigni arilivigni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we need this but LGTM

@scoheb
Copy link
Member Author

scoheb commented Aug 31, 2018

@arilivigni if you have previously outside of contra-env-setup and did not specify a display name in the create command, you need this fix.

@scoheb scoheb changed the title Support the case where project does not contain a description Support the case where project does not contain a display name Aug 31, 2018
@arilivigni
Copy link
Member

@scoheb not sure why we need a display name that seems specific to project requirements not a general contra-env-setup, correct?

@scoheb
Copy link
Member Author

scoheb commented Aug 31, 2018

@arilivigni The previous code assumed you had a display name set even though it is optional when creating a project. The awk '{print $3}' was not correct since the missing display name meant there was not 3 items...only 2

% oc get project cvp
NAME DISPLAY NAME STATUS
cvp Active

This PR handles both cases now...with or without display name.

@arilivigni
Copy link
Member

@scoheb I get it I just didn't think we even needed the code to set a display name since that seems specific to your project but works for me if CI passes

@arilivigni arilivigni merged commit 91edfee into CentOS-PaaS-SIG:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants