Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the query command for the minishift and oc compressed binaries #69

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

dirgim
Copy link
Collaborator

@dirgim dirgim commented Aug 15, 2018

Modified the commands which queries for the minishift and oc compressed binaries to cut off at the closing quote.
It seems the github links were updated recently, so without this change, the result of the command would be:
"https://github.com/minishift/minishift/releases/download/v1.17.0/minishift-1.17.0-linux-amd64.tgz\" rel="nofollow"

@dirgim dirgim requested a review from arilivigni August 15, 2018 13:23
Copy link
Member

@arilivigni arilivigni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arilivigni arilivigni merged commit 8fa62a8 into CentOS-PaaS-SIG:master Aug 15, 2018
@dirgim
Copy link
Collaborator Author

dirgim commented Aug 16, 2018

[test]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants