Create new minishift profile in case it was never created before #67
Conversation
psiroky
force-pushed
the
fix-minishift-profile-create
branch
from
740c19a
to
775e1dc
Compare
|
@arilivigni or @dirgim could you please take a quick look? |
| @@ -58,4 +58,4 @@ | |||
|
|
|||
| # Initialize minishift | |||
| - import_tasks: init_minishift.yml | |||
| when: minishift_exist.stdout != "" | |||
| when: (minishift_profile_status.stdout|lower == "does not exist") or minishift_profile_status.rc != 0 | |||
There was a problem hiding this comment.
why parens around one and not the other if you are going to use them?
There was a problem hiding this comment.
I kept those parens in as the conditional seems easier to read then (but I can also remove it if preferred).
There are two similar cases, which both need to be covered:
1) `minishift status --profile <name>` will return "Does not exist",
in case someone already configured the profile with `minishift
profile set <name>`(or in case it got deleted with `minishift delete`).
2) `minishift status --profile <name>` will return error saying the
profile doesn't exist at all (e.g. this is the first time it is being
used and queried for). `minishift start` will then create that profile.
This change brings support for case 2), by checking the result code of
the `minishift status` call.
psiroky
force-pushed
the
fix-minishift-profile-create
branch
from
775e1dc
to
f59a330
Compare
|
If you run That specific profile was never used, so minishift is not aware of that name. One other alternative would be to call |
|
@psiroky gotcha your approach is fine then, just one nit on the or in parens that I made a comment on. |
|
@arilivigni so I added the parens to the right side of the |
There are two similar cases, which both need to be covered:
minishift status --profile <name>will return "Does not exist",in case someone already configured the profile with
minishift profile set <name>(or in case it got deleted withminishift delete).minishift status --profile <name>will return error saying theprofile doesn't exist at all (e.g. this is the first time it is being
used and queried for).
minishift startwill then create thatprofile.
This change brings support for case 2), by checking the result code of
the
minishift statuscall.