Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log and cleanup failed builds #65

Merged
merged 3 commits into from
Aug 10, 2018

Conversation

dirgim
Copy link
Collaborator

@dirgim dirgim commented Aug 10, 2018

This change handles the logging and cleanup of failed builds:

  • Record which resources were created from the template when we run the new-app command
  • Clean all the recorded resources related to the template up if the build failed
  • Detect if the build failed instantly (while we were waiting for it to be scheduled)
  • Save logs of failed builds to log directory in /tmp/contra-env-setup/logs/run-$timestamp/
  • If any of the builds failed, output debug message with the specific log directory location

@dirgim dirgim requested a review from arilivigni August 10, 2018 11:16
Copy link
Member

@arilivigni arilivigni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as it has been tested

@arilivigni arilivigni merged commit 9383d5f into CentOS-PaaS-SIG:master Aug 10, 2018
@dirgim dirgim deleted the log-failed-builds branch August 31, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants