Changed README and going to use package instead of yum and dnf #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Minor README update * Using package instead of yum and dnf (These are not blockers)
|
lgtm |
dirgim
approved these changes
Aug 10, 2018
skatlapa
reviewed
Aug 10, 2018
| @@ -47,5 +38,4 @@ | |||
| - jq | |||
| - libselinux-python | |||
| - git | |||
| when: ansible_distribution == 'RedHat' or ansible_distribution == 'CentOS' | |||
There was a problem hiding this comment.
I did not quite understand the logic behind dropping fedora. If we only support rpm based, I guess it's better to drop the condition itself, imo.
There was a problem hiding this comment.
@skatlapa it is for setting up EPEL or not setting up EPEL on Fedora since it isn't needed and before it was for yum and dnf.
So now there is no need on this line since we will always install these packages using package.
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(These are not blockers)