Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backslash escaping for failed build cleanup filters #60

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

dirgim
Copy link
Collaborator

@dirgim dirgim commented Jun 29, 2018

Fix for failed build cleanups - the backslash wasn't escaped.

@dirgim dirgim requested a review from arilivigni June 29, 2018 11:18
@lslebodn
Copy link

+1 it fixed issue for me:

TASK [os_temps : include_tasks] **************************************************************************
fatal: [localhost]: FAILED! => {"reason": "Syntax Error while loading YAML.\n  found unknown escape character\n\nThe error appears to have been in '/root/contra-env-setup/playbooks/roles/os_temps/tasks/setup_containers.yml': line 38, column 70, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n- name: \"Check for all failed apps on the cluster\"\n  shell: \"{{ oc_bin }} get all | egrep 'Failed|Error' | egrep 'builds\\/' | awk '{print $1}' | awk -F'/' '{print $2}' | sed 's/-[0-9+]//g' \"\n                                                                     ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing quotes.  Always quote template expression brackets when they\nstart a value. For instance:\n\n    with_items:\n      - {{ foo }}\n\nShould be written as:\n\n    with_items:\n      - \"{{ foo }}\"\n"}
        to retry, use: --limit @/root/contra-env-setup/playbooks/setup.retry

PLAY RECAP ***********************************************************************************************
localhost                  : ok=22   changed=16   unreachable=0    failed=1

@arilivigni arilivigni merged commit 847b7d6 into CentOS-PaaS-SIG:master Jun 29, 2018
@dirgim dirgim deleted the fix-cleanup-bug branch August 31, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants