-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build container images in parallel #59
Conversation
LGTM - this is a great improvement! I can confirm the ~40% improvement when running CVP setups. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also take care of cleanup issues?
Only partially, I'm testing some additional cleanup fixes right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should wait and add it to this PR?
I was thinking of making any major changes to cleanup a separate PR. This last commit is just a small fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change introduces parallel builds in the playbooks/roles/os_temps/setup_containers.yml task in the following manner:
In testing, building container images in parallel tended to be 40% faster on average than building them sequentially.