Fix small bugs and add pre- and post-hooks to some roles #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Okay, I also cleaned up some inconsistencies with the startup logic for minishift, and I added some pre- and post-hooks for some of the roles. That way, I can inject the CA cert into minishift when its done being setup but before CVP is deployed. |
dirgim
reviewed
Dec 10, 2020
dirgim
reviewed
Dec 10, 2020
dirgim
requested changes
Dec 10, 2020
wheelerlaw
changed the title
|
I updated the PR with the requested changes, and also updated the title and description of the PR to reflect the scope of the changes. |
wheelerlaw
force-pushed
the
fix_cleanup
branch
from
5fc01ed
to
cdefe88
Compare
|
Reworded commit message, and squashed all commits into one. |
wheelerlaw
force-pushed
the
fix_cleanup
branch
from
cdefe88
to
95744f3
Compare
dirgim
reviewed
Dec 11, 2020
…e startup logic, and added some pre- and post-hooks to some of the roles.
wheelerlaw
force-pushed
the
fix_cleanup
branch
from
95744f3
to
fd2ddf1
Compare
|
Added some more tweaks, and squashed. |
|
@dirgim Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed this in the output:
You can see in the
Cleanup /home/wlaw/.contra-env-setup/pipelinetask, it is prepending the path with another path, making the path invalid, so it is skipped.Also as a part of this MR, the behavior around
start_minishiftwas made more consistent, since how that variable was used depended on whether minishift was being provisioned locally or on a remote VM. Now it is more consistent, in that thestart_minishiftvariable is respected regardless if the VM is local or remote. The default value forstart_minishiftwas changed totrue, since it is being started anyway by theos_tempsplaybook.Finally, pre- and post-hooks were added to some of the playbooks to support adding in custom behavior by any consumers of this project.