Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KVM driver installation: Add quotes to jinja2 var #144

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Conversation

skatlapa
Copy link
Contributor

This fixes KVM driver pulling step as it currently fails in local env due to jinja2 templating[1]. Adjusting this as per docs[2]
[1] - http://pastebin.test.redhat.com/704084
[2] - https://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#hey-wait-a-yaml-gotcha

This fixes KVM driver pulling step as it currently fails in local env due to jinja2 templating[1]. Adjusting this as per docs[2]
[1] - http://pastebin.test.redhat.com/704084
[2] - https://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#hey-wait-a-yaml-gotcha
@skatlapa
Copy link
Contributor Author

For some reason, I still see failure[1] despite the fix in my local env.. any inputs? @arilivigni @joejstuart @dirgim

@dirgim
Copy link
Collaborator

dirgim commented Jan 29, 2019

Can you find the driver in /usr/local/bin and is it in your path? Can't see why it would't work otherwise...

@skatlapa
Copy link
Contributor Author

skatlapa commented Jan 29, 2019

yea, I did and still not working :/
http://pastebin.test.redhat.com/704098

Btw.. would it be possible to try from scratch with current code in master(if you have a secondary env)? Now I am thinking its to do with ansible jinja2 maybe, LP had some similar issues, I think it could be related

@skatlapa skatlapa changed the title Fix KVM driver installation step [WIP]: Fix KVM driver installation step Jan 29, 2019
@skatlapa
Copy link
Contributor Author

It's working for me now. I had to copy from root/.. usr/local/bin to /usr/local/bin..

Will do a second run(removing pkg) to confirm, thanks for suggestions all.

P.S: I would like this PR to be merged else this yaml thing might hit us later I think

@skatlapa skatlapa changed the title [WIP]: Fix KVM driver installation step Fix KVM driver installation: Add quotes to jinja2 var Jan 29, 2019
Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skatlapa skatlapa merged commit 52fac9b into master Jan 29, 2019
@arilivigni arilivigni deleted the fix_kvm branch November 8, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants