Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove centos7-vagrant submodule from the repo #131

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

dirgim
Copy link
Collaborator

@dirgim dirgim commented Jan 8, 2019

Remove centos7-vagrant submodule from the repo to fix cloning problems.

@arilivigni arilivigni merged commit 83b2463 into CentOS-PaaS-SIG:master Jan 8, 2019
@skatlapa
Copy link
Contributor

skatlapa commented Jan 8, 2019

@dirgim Hey, the error for y'day was for submodules not retrieved while cloning. So we can do two things:

  1. Remove the submodules, which this PR did. And removing works perfectly if the submodules aren't needed(not sure if they're needed by any team).

  2. To get the submodules we need to clone the repo recursively, so I added the checkout stage in this PR[1]. We can check my cherrypicking the patch and try cloning, but either ways, I think we will need a checkout stage anyways(re this PR for now I can disable the parameter "recursiveSubmodules" if submodules are not needed). THis basically does "git clone --recursive"

@arilivigni I guess this also answers the question in the PR[1]. @joejstuart any thoughts?

[1] - https://github.com/CentOS-PaaS-SIG/contra-env-setup/pull/130/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants