-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test]: Update .gitignore to avoid stage errors #129
Conversation
This fixes submodule mapping errors while git cloning
Basically, this aims to fix this error: Cloning "https://github.com/CentOS-PaaS-SIG/contra-env-setup.git" ... |
# IntelliJ project files | ||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to ignore .idea and .pyc and .retry too
*.egg-info | ||
*.eggs | ||
*.log | ||
*.pyc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arilivigni they are here :) Should've pointed in the comments, my bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
If this still fails - for submodules use we need "git clone --recursive" so we can do that manually while cloning to w/a the error but for the CI, I believe the ghprb plugin does not support "--recursive" option atm.. @joejstuart would you have any idea about this? |
just keeping @ssegalredhat in loop.. |
Merging this, I will update the prepare environment stage in another PR shortly to address the CI for "--recursive" |
This fixes submodule mapping errors while git cloning