Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test]: Update .gitignore to avoid stage errors #129

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Conversation

skatlapa
Copy link
Contributor

@skatlapa skatlapa commented Jan 7, 2019

This fixes submodule mapping errors while git cloning

This fixes submodule mapping errors while git cloning
@skatlapa
Copy link
Contributor Author

skatlapa commented Jan 7, 2019

Basically, this aims to fix this error:

Cloning "https://github.com/CentOS-PaaS-SIG/contra-env-setup.git" ...
error: build error: No submodule mapping found in .gitmodules for path 'centos7-vagrant'

# IntelliJ project files
.idea
Copy link
Member

@arilivigni arilivigni Jan 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to ignore .idea and .pyc and .retry too

*.egg-info
*.eggs
*.log
*.pyc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arilivigni they are here :) Should've pointed in the comments, my bad.

Copy link
Member

@arilivigni arilivigni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skatlapa
Copy link
Contributor Author

skatlapa commented Jan 7, 2019

If this still fails - for submodules use we need "git clone --recursive" so we can do that manually while cloning to w/a the error but for the CI, I believe the ghprb plugin does not support "--recursive" option atm.. @joejstuart would you have any idea about this?

@skatlapa
Copy link
Contributor Author

skatlapa commented Jan 7, 2019

just keeping @ssegalredhat in loop..

@skatlapa
Copy link
Contributor Author

skatlapa commented Jan 7, 2019

Merging this, I will update the prepare environment stage in another PR shortly to address the CI for "--recursive"

@skatlapa skatlapa merged commit 96889e0 into master Jan 7, 2019
@arilivigni arilivigni deleted the fix_build_error branch November 8, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants