Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent simplified conditionals #127

Merged
merged 11 commits into from
Jan 8, 2019

Conversation

arilivigni
Copy link
Member

  • fixed all when statements for compound conditionals
  • fixed project_repo to point to contra-env-infra
  • only load containers from samples directory when setup_sample_project=true
  • issues with container-tools so blacklist for now
    • it loads as contra-env-infra and fedora instead of container-tools and fails

Ari LiVigni added 11 commits January 3, 2019 17:13
- the way s2i templates are supposed to be loaded does not work
- fixed all when statements for compound conditionals
- fixed project_repo to point to contra-env-infra
- only load containers from samples directory
- the way s2i templates are supposed to be loaded does not work
- fixed all when statements for compound conditionals
- fixed project_repo to point to contra-env-infra
- only load containers from samples directory
- the way s2i templates are supposed to be loaded does not work
- fixed all when statements for compound conditionals
- fixed project_repo to point to contra-env-infra
- only load containers from samples directory
- the way s2i templates are supposed to be loaded does not work
- fixed all when statements for compound conditionals
- fixed project_repo to point to contra-env-infra
- only load containers from samples directory
- the way s2i templates are supposed to be loaded does not work
- fixed all when statements for compound conditionals
- fixed project_repo to point to contra-env-infra
- only load containers from samples directory
- the way s2i templates are supposed to be loaded does not work
- fixed all when statements for compound conditionals
- fixed project_repo to point to contra-env-infra
- only load containers from samples directory
- the way s2i templates are supposed to be loaded does not work
- fixed all when statements for compound conditionals
- fixed project_repo to point to contra-env-infra
- only load containers from samples directory
- Re-introduce ssegal changes back
- fixed all when statements for compound conditionals
- fixed project_repo to point to contra-env-infra
- only load containers from samples directory
- Re-introduce ssegal changes back
- fixed all when statements for compound conditionals
- fixed project_repo to point to contra-env-infra
- only load containers from samples directory
- Re-introduce ssegal changes back
- fixed all when statements for compound conditionals
- fixed project_repo to point to contra-env-infra
- only load containers from samples directory
- Re-introduce ssegal changes back
- fixed all when statements for compound conditionals
- fixed project_repo to point to contra-env-infra
- only load containers from samples directory
- issues with container-tools so blacklist for now
Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this PR will need the changes in #128 to pass the tests

Copy link
Contributor

@joejstuart joejstuart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arilivigni
Copy link
Member Author

[test]

4 similar comments
@skatlapa
Copy link
Contributor

skatlapa commented Jan 7, 2019

[test]

@arilivigni
Copy link
Member Author

[test]

@arilivigni
Copy link
Member Author

[test]

@dirgim
Copy link
Collaborator

dirgim commented Jan 8, 2019

[test]

@arilivigni arilivigni merged commit 7a076c7 into CentOS-PaaS-SIG:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants