Install only jq in os_temps task, don't install virtual requirements #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@werne2j could you also take a look at this? I removed your condition as jq should be safe for Mac. |
|
@dirgim my only question would be is how is jq being installed here. I think it would be best to use homebrew to install any dependencies on mac. And not sure what this module uses as the mac package manager |
dirgim
force-pushed
the
install-jq-fix
branch
from
6861253
to
d1026d2
Compare
|
@werne2j good point, as it seems that |
|
Agreed |
arilivigni
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install only jq in the main os_temps role, don't include the installation of other virtual requirements as that bypasses the run_prereqs option.