-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to use contra-env-infra templates #116
Conversation
arilivigni
commented
Dec 4, 2018
- Update README with new examples and update current ones
- Example without minishift and sample project
- Modify globals
- versions of minishift/openshift
- new helper_container variables
- modify_scc to false
- Remove SAMPLE_PARAMS options
- Moved away from my fork since PR got merged
- Update TOC
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options * Moved away from my fork since PR got merged
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options * Moved away from my fork since PR got merged * Update TOC
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options * Moved away from my fork since PR got merged * blacklist influxdb and grafana * Update TOC
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options * Moved away from my fork since PR got merged * blacklist influxdb and grafana * Update TOC * Change to params instead of build_params since it applies to more than jsut builds
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options * Moved away from my fork since PR got merged * blacklist influxdb and grafana * Update TOC * Change to params instead of build_params since it applies to more than just builds * add params to override s2i template parameters
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options * Moved away from my fork since PR got merged * blacklist influxdb and grafana * Update TOC * Change to params instead of build_params since it applies to more than just builds * remove params completely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
``` | ||
ansible-playbook -vv -i "localhost," contra-env-setup/playbooks/setup.yml \ | ||
-e user=cloud-user -e project_repo=https://github.com/arilivigni/my-project-example \ | ||
-e openshift_project=ari-ci-pipeline -e setup_minishift=false -e start_minishift=true \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the point of having start_minishift=true
if setup_minishift=false
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One starts minishift if it has already been setup but may be stopped and the other sets it up. If you want more detail please look into the code. This functionality has been there for a while and introduced by the CVP team.