Move to use contra-env-infra templates #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arilivigni
commented
Dec 4, 2018
arilivigni
commented
- Update README with new examples and update current ones
- Example without minishift and sample project
- Modify globals
- versions of minishift/openshift
- new helper_container variables
- modify_scc to false
- Remove SAMPLE_PARAMS options
- Moved away from my fork since PR got merged
- Update TOC
added 6 commits
December 3, 2018 00:52
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options * Moved away from my fork since PR got merged
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options * Moved away from my fork since PR got merged * Update TOC
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options * Moved away from my fork since PR got merged * blacklist influxdb and grafana * Update TOC
dirgim
reviewed
Dec 4, 2018
added 3 commits
December 4, 2018 09:53
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options * Moved away from my fork since PR got merged * blacklist influxdb and grafana * Update TOC * Change to params instead of build_params since it applies to more than jsut builds
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options * Moved away from my fork since PR got merged * blacklist influxdb and grafana * Update TOC * Change to params instead of build_params since it applies to more than just builds * add params to override s2i template parameters
* Update README with new examples and update current ones * Example without minishift and sample project * Modify globals * versions of minishift/openshift * new helper_container variables * modify_scc to false * Remove SAMPLE_PARAMS options * Moved away from my fork since PR got merged * blacklist influxdb and grafana * Update TOC * Change to params instead of build_params since it applies to more than just builds * remove params completely
ifireball
reviewed
Dec 5, 2018
| ``` | ||
| ansible-playbook -vv -i "localhost," contra-env-setup/playbooks/setup.yml \ | ||
| -e user=cloud-user -e project_repo=https://github.com/arilivigni/my-project-example \ | ||
| -e openshift_project=ari-ci-pipeline -e setup_minishift=false -e start_minishift=true \ |
There was a problem hiding this comment.
whats the point of having start_minishift=true if setup_minishift=false ?
There was a problem hiding this comment.
One starts minishift if it has already been setup but may be stopped and the other sets it up. If you want more detail please look into the code. This functionality has been there for a while and introduced by the CVP team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.