Fix issue when username/password contain spaces #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue CentOS-PaaS-SIG#105 Signed-off-by: Barak Korren <bkorren@redhat.com>
|
Can one of the admins verify this patch? |
|
[test] |
|
This looks good to me, but when I tried applying the same logic to add_scc.yml#L6, it failed. I'll have to test it some more. |
|
Who has merge rights? @dirgim strange it does not work in the line you mentioned - can I see you patch and the failed test? |
arilivigni
reviewed
Nov 5, 2018
| command: "{{ oc_bin }} login {{ cluster_ip|quote }} --username={{ username|quote }} --password={{ password|quote }} --insecure-skip-tls-verify=true" |
There was a problem hiding this comment.
Why can't we leave this as a shell?
There was a problem hiding this comment.
safer this way - less chance of injection, also I suspect |quote does not really work well with shell.
|
@ifireball It's fine, I got it working. I'm good to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #105
Signed-off-by: Barak Korren bkorren@redhat.com