Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use future type annotations #7

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Use future type annotations #7

merged 4 commits into from
Mar 7, 2023

Conversation

janosh
Copy link
Collaborator

@janosh janosh commented Mar 7, 2023

Using the side-effect from __future__ import annotations, Python backports support for the 3.10 type annotation syntax all the way to 3.7.

@janosh
Copy link
Collaborator Author

janosh commented Mar 7, 2023

This line isort.required-imports = ["from __future__ import annotations"] in pyproject.toml makes ruff auto-add this import at the start of every file. This line and all the imports it adds can be removed once the minimum supported Python version for chgnet is 3.10.

@BowenD-UCB BowenD-UCB merged commit a580474 into CederGroupHub:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants