Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruff PERF203 + PERF401 violations #43

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Fix ruff PERF203 + PERF401 violations #43

merged 3 commits into from
Jul 3, 2023

Conversation

janosh
Copy link
Collaborator

@janosh janosh commented Jul 3, 2023

1adaf28 link docs from readme badge
3b0d635 bump ruff and opt in to beta notebooks linting
9688c97 fix ruff PERF203 + PERF401 violations

@janosh janosh added docs Improvements or additions to documentation linting Cleaning up and refactoring code labels Jul 3, 2023
@janosh janosh enabled auto-merge (squash) July 3, 2023 23:05
@janosh janosh temporarily deployed to github-pages July 3, 2023 23:09 — with GitHub Actions Inactive
@codacy-production
Copy link

Coverage summary from Codacy

Merging #43 (9688c97) into main (b568139) - See PR on Codacy

Coverage variation Diff coverage
Report missing for b5681391 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b568139) Report Missing Report Missing Report Missing
Head commit (9688c97) 1157 875 75.63%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#43) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@janosh janosh merged commit fd0b4cf into main Jul 3, 2023
7 checks passed
@janosh janosh deleted the list-comp branch July 3, 2023 23:11
lbluque pushed a commit to lbluque/chgnet that referenced this pull request Jul 10, 2023
* link docs from readme badge

* bump ruff and opt in to beta notebooks linting

* fix ruff PERF203 + PERF401 violations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation linting Cleaning up and refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant