docs: add createCartoTheme: look and feel & ui #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 0116e08): https://cartodb-fb-documentation--pr78-adri-add-createcarto-u8bfy7ez.web.app (expires Thu, 15 Apr 2021 14:20:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
| ... | ||
| import { cartoThemeOptions, createCartoTheme } from '@carto/react-ui'; | ||
| ... | ||
| cartoThemeOptions.palette.primary.main = "#800000"; |
There was a problem hiding this comment.
@AdriSolid don't we need to pass here the object to the new method as param?
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| A set of UI elements to build CARTO for React applications. | |||
|
|
|||
| The package includes 2 main elements: a set of values to use a Material UI theme with CARTO brand (`cartoThemeOptions`) + a group of widgets: | |||
| The package includes 2 main elements: a set of values to use a Material UI theme with CARTO brand (`createCartoTheme` and `cartoThemeOptions`) + a group of widgets: | |||
There was a problem hiding this comment.
As createCartoTheme is strictly a method, how about...
The package includes some utilities to create a Material UI theme with CARTO brand (createCartoTheme and cartoThemeOptions) + a group of widgets
Jesus89
force-pushed
the
master
branch
2 times, most recently
from
db0116a
to
3121397
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CARTO for React: docs for
createCartoTheme.