Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ch160203] OauthApps restricted by default #16304

Merged
merged 4 commits into from
Jun 17, 2021
Merged

[ch160203] OauthApps restricted by default #16304

merged 4 commits into from
Jun 17, 2021

Conversation

Shylpx
Copy link
Collaborator

@Shylpx Shylpx commented Jun 15, 2021

Resources

Context

  • OAuth apps should use the restricted attribute by default.

Changes

  • Set restricted to true for Carto::OauthApp by default for users with an organization.
  • Create corresponding Carto::OauthAppOrganization for the user's organization.

@Shylpx Shylpx self-assigned this Jun 15, 2021
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #160203: Review OAuth application restriction to organization users only.

@Shylpx Shylpx requested a review from amiedes June 15, 2021 16:51
amiedes
amiedes requested changes Jun 16, 2021
View reviewed changes
spec/models/carto/oauth_app_spec.rb Outdated Show resolved Hide resolved
spec/models/carto/oauth_app_spec.rb Outdated Show resolved Hide resolved
@amiedes
Copy link
Contributor

amiedes commented Jun 16, 2021

I think the Rubocop CI hook is broken 😢 because it should be spotting this:

image

@amiedes amiedes self-requested a review June 16, 2021 10:19
amiedes
amiedes approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@amiedes amiedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🍻

@Shylpx Shylpx merged commit 53b564f into master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiedes amiedes amiedes approved these changes

Assignees

@Shylpx Shylpx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shylpx @amiedes