Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug reassigning geocodings #15924

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Fix bug reassigning geocodings #15924

merged 1 commit into from
Nov 11, 2020

Conversation

amiedes
Copy link
Contributor

@amiedes amiedes commented Nov 11, 2020

before { create(:carto_geocoding, user: user) }

it 'assigns geocodings to organization owner' do
expect(organization_owner.geocodings.count).to eq(0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amiedes
Copy link
Contributor Author

amiedes commented Nov 11, 2020

Acceptance in staging

  1. Create organization with users
  2. As organization user, upload dataset with geocodable information
  3. Check geocodings data from the console:
irb(main):006:0> admin.username
# => "amiedes-geocodings-admin"
irb(main):007:0> user.username
# => "amiedes-geocodings-1"
irb(main):008:0> admin.geocodings.count
# => 0
irb(main):009:0> user.geocodings.count
# => 1
  1. Delete organization user from the dashboard admin UI
  2. Check from the console if geocodings were assigned to the admin:
irb(main):010:0> user.geocodings.count
# => 0
irb(main):011:0> admin.geocodings.count
# => 1

@amiedes
Copy link
Contributor Author

amiedes commented Nov 11, 2020

Frontend tests failures should be unrelated 🤷‍♂️

@amiedes amiedes merged commit 8eb5216 into master Nov 11, 2020
@amiedes amiedes deleted the amiedes/fix-rollbar-43590 branch November 11, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants