Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Snowflake, Redshift connectors UI #15814

Merged
merged 32 commits into from
Sep 22, 2020
Merged

Add Snowflake, Redshift connectors UI #15814

merged 32 commits into from
Sep 22, 2020

Conversation

Jesus89
Copy link
Member

@Jesus89 Jesus89 commented Sep 4, 2020 •
edited
Loading

  • Refactor connectors UI
    • Custom grid style (3xn)
    • Custom order
    • Custom placeholder query
    • Custom parametric form params
    • Add optional values
    • Hide titles of empty sections
    • Fix "more features" upgrade link
    • Review connectors visibility logic
    • Add custom sql-hint for Snowflake
  • Add Snowflake connector UI
    • Server
    • Database
    • Username
    • Password
    • Warehouse (optional)
  • Add Redshift connector UI
    • Cluster
    • Port
    • Database
    • Username
    • Password
  • Add Dashboard notification (only with carto-connectors FF)

@Jesus89 Jesus89 marked this pull request as ready for review September 7, 2020 13:05
Jesus89 and others added 9 commits September 7, 2020 15:16
@VictorVelarde
Copy link
Contributor

I reviewed this yesterday, but it looks like my comment was not recorded... anyway good job on that params generalization.
I have no accounts for testing, any option to have it deployed at staging + some connection strings for acceptance?

@Jesus89
Copy link
Member Author

Jesus89 commented Sep 17, 2020

Thanks!. And yes, you can test this in staging: https://snowtest2.carto-staging.com/.

More info here:

@VictorVelarde
Copy link
Contributor

I could run the acceptance on snowflake, but I wasn't able to get redshift running. I can try again after your checks

jgoizueta and others added 2 commits September 21, 2020 09:32
@jgoizueta
Merge branch 'master' into feature/ch99087/implement-snowflake-connec…
997d38f 
…tor-frontend
@Jesus89
Merge branch 'feature/ch99087/implement-snowflake-connector-frontend'…
987808a 
… of github.com:CartoDB/cartodb into feature/ch99087/implement-snowflake-connector-frontend
@Jesus89 Jesus89 force-pushed the feature/ch99087/implement-snowflake-connector-frontend branch from 62f1093 to f0d19b1 Compare September 21, 2020 10:02
@Jesus89 Jesus89 force-pushed the feature/ch99087/implement-snowflake-connector-frontend branch from f0d19b1 to 9e34405 Compare September 21, 2020 10:04
VictorVelarde
VictorVelarde approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, Nice additions!. Just double-check with QA the redshift connector

@VictorVelarde
Copy link
Contributor

Check travis! 👀

@Jesus89 Jesus89 merged commit e5ad682 into master Sep 22, 2020
@Jesus89 Jesus89 deleted the feature/ch99087/implement-snowflake-connector-frontend branch September 22, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVelarde VictorVelarde VictorVelarde approved these changes

@padawannn padawannn Awaiting requested review from padawannn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jesus89 @VictorVelarde @jgoizueta