Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Coverband #15811

Merged

Conversation

amiedes
Copy link
Contributor

@amiedes amiedes commented Sep 3, 2020

Closes the backend part of: https://app.clubhouse.io/cartoteam/story/97636/add-a-dead-code-detector-that-we-can-use-in-production

What does this PR do?

Installs https://github.com/danmayer/coverband. Access is restricted in production to the team organization users.

Related infra work

There are still a few pending changes in https://github.com/CartoDB/cartodb-platform/pull/6882, but it should not affect this PR: if Coverband can't connect to redis simply it shows an error but does not affect normal CartoDB behavior.

@amiedes amiedes force-pushed the feature/ch97636/add-a-dead-code-detector-that-we-can-use branch 4 times, most recently from c3c2e6a to 07906ff Compare September 7, 2020 11:21
@amiedes amiedes marked this pull request as ready for review September 7, 2020 15:51
Copy link
Contributor

@rafatower rafatower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amiedes amiedes force-pushed the feature/ch97636/add-a-dead-code-detector-that-we-can-use branch from caba98d to d6b7ce2 Compare September 9, 2020 09:49
@amiedes amiedes merged commit 3f76d4c into master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants