Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update footer links based on account types #15502

Merged
merged 7 commits into from
Feb 26, 2020
Merged

Update footer links based on account types #15502

merged 7 commits into from
Feb 26, 2020

Conversation

alejandraarri
Copy link
Contributor

@alejandraarri alejandraarri commented Feb 26, 2020

Remove Tech Support link from all account types and remove Dedicated Support from Students accounts.

Copy link
Contributor

@elenatorro elenatorro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, but it LGTM 🚀

@@ -68,12 +62,12 @@ export default {
},

isFreeUser () {
const freeUser = ['free', 'free 2020', 'carto for students - anual'];
const freeUser = ['free'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use these user types from the account types constants?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@alejandraarri alejandraarri merged commit 4db4bdb into master Feb 26, 2020
@alejandraarri alejandraarri deleted the footer-links branch February 26, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants