Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO] Token endpoint #15097

Merged
merged 4 commits into from
Sep 24, 2019
Merged

[DO] Token endpoint #15097

merged 4 commits into from
Sep 24, 2019

Conversation

gonzaloriestra
Copy link
Contributor

Related to #15077

Copy link
Contributor

@simon-contreras-deel simon-contreras-deel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alrocar
Copy link
Contributor

alrocar commented Sep 19, 2019

If I'm not wrong we added this issue to avoid having to call central for the token.

Right now, I think we can try with the current approach in this PR. It will add a little bit more of latency but since the whole process is batch and it happens once every hour I think it's fine.

@gonzaloriestra
Copy link
Contributor Author

@alrocar I thought we changed the approach when we decided to use the short-lived access tokens, but I guess we could sync the key anyway and request the token directly from cartodb. Anyway, yes, we can improve it in the next iteration.

@alrocar
Copy link
Contributor

alrocar commented Sep 19, 2019

@gonzaloriestra sure, no problem. Let's move forward!

@simon-contreras-deel
Copy link
Contributor

simon-contreras-deel commented Sep 23, 2019

Acceptance 🍏

@gonzaloriestra gonzaloriestra merged commit f9960fa into master Sep 24, 2019
@gonzaloriestra gonzaloriestra deleted the token-endpoint branch September 24, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants