[Dashboard Removal] Migrated Dashboard

[jesusbotella]

This PR removes the migrated dashboard page from the repository.

This is not the old dashboard contained within cartodb. That one will be removed in another PR.

This migrated dashboard page is within lib/assets/javascripts/dashboard and its entry point is dashboard.js.

This dashboard page is not used anymore because of the new dashboard has been put in place. So, it's time to clean it.

The dashboard bundle was compiled with Webpack and its dependencies were defined in:

cartodb/webpack/v4/entryPoints.js

Lines 22 to 27 in 9659826

	dashboard: [
	rootDir('lib/assets/javascripts/dashboard/dashboard.js'),
	...glob.sync(rootDir('assets/stylesheets/dashboard/*.scss')),
	rootDir('assets/stylesheets/editor-3/_scroll-view.scss'),
	rootDir('node_modules/internal-carto.js/themes/scss/entry.scss')
	],

So, doing an static analysis, we got the dependency files to remove that were detailed in https://github.com/CartoDB/product/issues/289 and removed in this pull request.

The removal is safe because we discarded the files being used in dashboard and other entry points so that we don't remove them causing a failure when building the bundle.

https://github.com/CartoDB/product/issues/289

[jesusbotella]

This PR is ready to review 🎉

It'd be great if @javitonino can give it a look just in case I missed something to remove and review the FF removal.

And for the FrontEnd part, I invoke @rjimenezda as we worked on the dashboard migration to give it a look.

cc/ @VictorVelarde

[javitonino]

I think I found a 🐛

[javitonino]

I think this is incorrect. I think common and common-vendor should be always included (they were previously included if you had the new dashboard). I feel this will break the assets for people without engine (e.g: FREEs)

[jesusbotella]

I refactored a bit this page when including the new header and footer, and the thing is that no assets are needed for people without Engine enabled!

When there's no engine enabled, it includes api_keys_cta partial template here:

cartodb/app/views/admin/client_applications/api_key.html.erb

Lines 41 to 45 in b67c27f

	<% if @has_engine_enabled %>
	<div class="api-keys js-api-keys-new"></div>
	<% else %>
	<%= render :partial => 'api_keys_cta' %>
	<% end %>

Which according to the template, it doesn't need any JavaScript to render the partial or any of the content there.

[alonsogarciapablo]

🔥🔥🔥🔥?

[jesusbotella]

It is the first stage, but yes, the migrated dashboard is no longer there :)

[alonsogarciapablo]

👏 👏 👏