Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @emotion & @mui to latest and some cleanup #790

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

VictorVelarde
Copy link
Contributor

Description

Shortcut: 351003

  • Bump mui to latest in v5
  • Bump to latest @emotion minor
  • Removal of styled-components peer dep (cleaning)

Companion PR in c4r-template: ?

Type of change

  • Chore

Acceptance

No issues or visual changes in storybook.

A must before the release is also to verify / adapt not only templates but cloud-native

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@VictorVelarde VictorVelarde marked this pull request as draft October 11, 2023 14:47
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Visit the preview URL for this PR (updated for commit c5f90c1):

https://cartodb-fb-storybook-react-dev--pr790-bump-mui-9geheczp.web.app

(expires Tue, 24 Oct 2023 09:12:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant