Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gmaps basemap types #760

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix gmaps basemap types #760

wants to merge 2 commits into from

Conversation

VictorVelarde
Copy link
Contributor

Description

Shortcut: sc-339329

Wrong basemap type for google basemap

Type of change

  • Fix
  • Feature
  • Refactor
  • Tests
  • Documentation

Acceptance

Consume 'GOOGLE_SATELLITE' as a coorect basemap type, without TS errors, in a carto-react-template using TS

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #339329: Wrong type in Google basemap, in carto for react 2.x.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Visit the preview URL for this PR (updated for commit 67009b1):

https://cartodb-fb-storybook-react-dev--pr760-fix-gmaps-types-pc8k6voz.web.app

(expires Fri, 06 Oct 2023 18:23:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant