Update tooling to support ts files #358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 25, 2022 11:52
Pull Request Test Coverage Report for Build 1917513354
💛 - Coveralls |
zbigg
reviewed
Mar 4, 2022
packages/react-api/package.json
Outdated
| @@ -18,15 +18,15 @@ | |||
| "lib": "src", | |||
| "test": "__tests__" | |||
| }, | |||
| "types": "src/index.d.ts", | |||
| "types": "src/index.ts", | |||
There was a problem hiding this comment.
It is in general discouraged to publish 'ts' files as typings
By publishing ts sources, you're forcing user to rely on "our" subset of typescript settings which arenot necessarily compatible with that of user project (like noImplicitAny, strictNullChecks...)
most configurations of typescript will not even compile them as they specifically exclude node_modules
thus, we still should publish .d.ts files, but generated using tsc
added 2 commits
March 16, 2022 19:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.