Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Storybook showing args instead of properties #172

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented Sep 22, 2021

Story details: https://app.shortcut.com/cartoteam/story/147101

Using docs.code.type dynamic and jsx options it's possible to get dynamic source code.

Also, I've made a little clean to avoid undefined values and inconsistencies in stories.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #147101: Storybook shows args instead of properties.

@coveralls
Copy link
Collaborator

coveralls commented Sep 22, 2021

Pull Request Test Coverage Report for Build 1740264980

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.415%

Totals Coverage Status
Change from base Build 1740086684: 0.0%
Covered Lines: 1155
Relevant Lines: 1544

💛 - Coveralls

@VictorVelarde VictorVelarde changed the title Storybook shows args instead of properties Fix Storybook shows args instead of properties Oct 19, 2021
@VictorVelarde VictorVelarde changed the title Fix Storybook shows args instead of properties Fix Storybook showing args instead of properties Oct 19, 2021
@VictorVelarde
Copy link
Contributor

VictorVelarde commented Oct 19, 2021

The approach looks nice, but there are some pending stuff here. I think it needs a pretty detailed QA to find all

For example:
Note: Always left (current / prod) vs right (local / this PR)

  • FormulaWidgetUI --> inline function is ignored)
    image

  • Palette --> not using theme, but hardcoded values
    image

Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still pending work here. There are several cases in which, IMO, code doesn't display as expected

@VictorVelarde
Copy link
Contributor

@borja-munoz putting this on-hold in the meantime

…47101/storybook-shows-args-instead-of-properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants