Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to Optimize Performance & Memory Usage #7

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

graphemecluster
Copy link
Member

No description provided.

Copy link
Member

@laubonghaudoi laubonghaudoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

根據 https://github.com/CanCLID/ToJyutping/actions/runs/10014819429/job/27685237266 嘅測試,Ubuntu 下 Python 3.10 test_get_jyutping_performance

___________ TestToJyutpingPerformance.test_get_jyutping_performance ____________
----------------------------- Captured stdout call -----------------------------
Benchmark:
Time (mean ± ּσ):      2.381 ms ±    0.060 ms
Range (min … ּmax):    2.342 ms …    3.985 ms
p75, p95, p975:       2.386 ms,     2.419 ms,     2.445 ms

好似好唔錯,比原先仲快?

@graphemecluster
Copy link
Member Author

@laubonghaudoi 我都見到,係快咗,但係你覺得呢個 code pattern 點?Memory usage 係咪都好咗?

@laubonghaudoi
Copy link
Member

我覺得冇問題,內存使用嗰啲我冇測過我都唔知,但係如果實際跑過得嘅話我覺得唔使擔心。如果真係有咩需要改進嘅話可能就係加啲docstring同readme,費事以後第個人維護都睇唔明。

@graphemecluster graphemecluster merged commit 7c6a724 into main Jul 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants