[Fix](mlu-ops): Fix an error of perf analyser #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanieeelLiu
reviewed
Apr 7, 2024
PetrelYy
reviewed
Apr 7, 2024
|
Motivation 需要详细介绍为什么这样改的原因，而不是错误现象：多个算子有可能有同名的测例文件，使用测例的文件名当做键值不合理，应该使用测例的绝对路径当做键值 |
Fix the name of prototype so that there is no duplicated names.
ZhouxiangZhouxiang
force-pushed
the
benchmark_campare
branch
from
4bb0f16
to
4558808
Compare
DanieeelLiu
approved these changes
Apr 9, 2024
chqy99
approved these changes
Apr 9, 2024
PetrelYy
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the name of prototype so that there is no duplicated names.
Thanks for your contribution and we appreciate it a lot. 🚀🚀
1. Motivation
When we run the perf tool to compare multiple operators, the comparison can fail. The reason is that 2 dataframes need to be merged according to their common keys called "protoName". ProtoNames are the names of calculators' testcases, which means there are a lot of repetitive ones like case0 or case_0. But as a key, protoName should be unique in each dataframe. Repetitive names means that merging 2 dataframes can result in incorrect results.
2. Modification
I have changed the name of the protoname in function preprocess in file parser.py to the full path of the test case of each calculator so that there are no repeated protoNames.
3. Test Report
This is the png generated by the python file for all the calculators, which means the now the bug is solved.
