Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](bangc-ops): fix border_align #779

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

PetrelYy
Copy link
Collaborator

@PetrelYy PetrelYy commented Jul 17, 2023

Thanks for your contribution and we appreciate it a lot.

1. Motivation

fix split-c mode in border_align
fix some potential error, like mem leaks, et

2. Modification

modified:   ../kernels/border_align_backward/border_align_backward.cpp
modified:   ../kernels/border_align_backward/border_align_backward.h
modified:   ../kernels/border_align_backward/border_align_backward_union1.mlu
modified:   ../kernels/border_align_forward/border_align_forward.cpp
modified:   ../kernels/border_align_forward/border_align_forward.h
modified:   ../kernels/border_align_forward/border_align_forward_union1.mlu
modified:   ../kernels/utils/common.h
modified:   ../test/mlu_op_gtest/pb_gtest/src/zoo/border_align_forward/border_align_forward.cpp
modified:   ../../docs/bangc-docs/design_docs/border_align_forward/border_align_forward.md
renamed:    ../../docs/bangc-docs/design_docs/border_align_forward/figure3.png -> ../../docs/bangc-docs/design_docs/border_align_forward/figure.png
deleted:    ../../docs/bangc-docs/design_docs/border_align_forward/figure1.png
deleted:    ../../docs/bangc-docs/design_docs/border_align_forward/figure2.png

3. Test Report

370 & 590 all
release_temp、nan/inf、large-c、near_2g_num case all pass

@PetrelYy PetrelYy force-pushed the border_align_forward branch 2 times, most recently from 3d8f194 to c1ad4c0 Compare July 19, 2023 03:08
@PetrelYy PetrelYy changed the title [Fix](bangc-ops): fix border_align_forward doc [Fix](bangc-ops): fix border_align_forward Jul 19, 2023
@PetrelYy PetrelYy force-pushed the border_align_forward branch 3 times, most recently from 7d98678 to b39f849 Compare July 26, 2023 09:50
@PetrelYy PetrelYy force-pushed the border_align_forward branch 4 times, most recently from df86567 to f595f5f Compare July 27, 2023 03:21
@PetrelYy PetrelYy changed the title [Fix](bangc-ops): fix border_align_forward [Fix](bangc-ops): fix border_align Aug 1, 2023
- `top` ,`x_stride = box_height / pool_size; y_stride = 0;`
- `left` ,`x_stride = 0; y_stride = box_height / pool_size;`
- `bottom` ,`x_stride = box_height / pool_size; y_stride = 0;`
- `right` ,`x_stride = box_height / pool_size; y_stride = 0;`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

topx_stride = box_height / pool_size; y_stride = 0;
leftx_stride = 0; y_stride = box_height / pool_size;
bottomx_stride = -box_height / pool_size; y_stride = 0;
rightx_stride = 0; y_stride = -box_height / pool_size;

@PetrelYy PetrelYy force-pushed the border_align_forward branch 3 times, most recently from 41912f3 to acb9818 Compare August 3, 2023 07:25
@PetrelYy PetrelYy merged commit b1fb803 into Cambricon:master Aug 3, 2023
1 check passed
@PetrelYy PetrelYy deleted the border_align_forward branch August 3, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants