-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](bangc-ops): fix border_align #779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrelYy
force-pushed
the
border_align_forward
branch
2 times, most recently
from
July 19, 2023 03:08
3d8f194
to
c1ad4c0
Compare
PetrelYy
changed the title
[Fix](bangc-ops): fix border_align_forward doc
[Fix](bangc-ops): fix border_align_forward
Jul 19, 2023
PetrelYy
force-pushed
the
border_align_forward
branch
3 times, most recently
from
July 26, 2023 09:50
7d98678
to
b39f849
Compare
Unireverse
reviewed
Jul 26, 2023
bangc-ops/kernels/border_align_forward/border_align_forward_union1.mlu
Outdated
Show resolved
Hide resolved
Unireverse
reviewed
Jul 26, 2023
bangc-ops/kernels/border_align_forward/border_align_forward_union1.mlu
Outdated
Show resolved
Hide resolved
PetrelYy
force-pushed
the
border_align_forward
branch
4 times, most recently
from
July 27, 2023 03:21
df86567
to
f595f5f
Compare
PetrelYy
commented
Jul 27, 2023
PetrelYy
force-pushed
the
border_align_forward
branch
from
August 1, 2023 07:44
99e736f
to
ff8d05a
Compare
PetrelYy
force-pushed
the
border_align_forward
branch
from
August 1, 2023 07:46
ff8d05a
to
9815af5
Compare
PetrelYy
changed the title
[Fix](bangc-ops): fix border_align_forward
[Fix](bangc-ops): fix border_align
Aug 1, 2023
mahxn0
reviewed
Aug 2, 2023
docs/bangc-docs/design_docs/border_align_forward/border_align_forward.md
Outdated
Show resolved
Hide resolved
docs/bangc-docs/design_docs/border_align_forward/border_align_forward.md
Outdated
Show resolved
Hide resolved
mahxn0
reviewed
Aug 2, 2023
- `top` ,`x_stride = box_height / pool_size; y_stride = 0;` | ||
- `left` ,`x_stride = 0; y_stride = box_height / pool_size;` | ||
- `bottom` ,`x_stride = box_height / pool_size; y_stride = 0;` | ||
- `right` ,`x_stride = box_height / pool_size; y_stride = 0;` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
top
,x_stride = box_height / pool_size; y_stride = 0;
left
,x_stride = 0; y_stride = box_height / pool_size;
bottom
,x_stride = -box_height / pool_size; y_stride = 0;
right
,x_stride = 0; y_stride = -box_height / pool_size;
DanieeelLiu
reviewed
Aug 3, 2023
docs/bangc-docs/design_docs/border_align_forward/border_align_forward.md
Show resolved
Hide resolved
PetrelYy
force-pushed
the
border_align_forward
branch
3 times, most recently
from
August 3, 2023 07:25
41912f3
to
acb9818
Compare
PetrelYy
force-pushed
the
border_align_forward
branch
from
August 3, 2023 07:28
acb9818
to
406f9a0
Compare
mahxn0
approved these changes
Aug 3, 2023
Unireverse
approved these changes
Aug 3, 2023
DanieeelLiu
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot.
1. Motivation
fix split-c mode in border_align
fix some potential error, like mem leaks, et
2. Modification
3. Test Report
370 & 590 all
release_temp、nan/inf、large-c、near_2g_num case all pass