Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](bangc-ops): fix memory leak #724

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

PetrelYy
Copy link
Collaborator

@PetrelYy PetrelYy commented Jun 7, 2023

Thanks for your contribution and we appreciate it a lot.

1. Motivation

Feature: fix memory leak

2. Modification

[Please briefly describe what modification is made in this pull request, and indicate where to make the modification.](modified: ../test/mlu_op_gtest/pb_gtest/src/zoo/dynamic_point_to_voxel_forward/dynamic_point_to_voxel_forward.cpp)

3. Test Report

If you want to know how to do operator testing, you can see GTest-User-Guide-zh.

3.1 Modification Details

3.1.1 Accuracy Acceptance Standard

For static threshold standard details, see: MLU-OPS Accuracy Acceptance Standard.

  • diff1: diff1 <= 3e-3
  • diff2: diff2 <= 3e-3

3.1.2 Operator Scheme checklist

No. Details Check Results
1 Supported hardware MLU370
MLU590
2 Job types block
U1
U4
3 Layouts NHWC 、NCHW、ARRAY etc
4 Whether multi-dimensions are supported
5 Whether element zero is supported
6 Data type(half/float) half / float etc
7 Whether there is size limit

3.1.3 New Feature Test

If you have checked the following items, please tick the relevant box.

  • Data type test
  • Multi-dimensional tensor test
  • Layout test
  • Different size/integer remainder end segment/alignment misalignment test
  • Zero dimensional tensor test/zero element test
  • stability test
  • Multiple platform test
  • Gen_case module test
  • Nan/INF tests
  • Bug fix tests
  • For memory leak check details, seeGTest-User-Guide-zh.
  • For code coverage check details, see: GTest-User-Guide-zh.
  • For I/O calculation efficiency check details, see: MLU-OPS Performance Acceptance Standard.

3.1.4 Parameter Check

When a new operator is submitted, the test points are given and the test results are stated.

Test Point Acceptance Standard Test Result (Error Message)
Whether it conforms to the operator restriction Normal error
Whether illegal parameters are passed Normal error

3.2 Accuracy Test

For the cases used in the New Feature Test section, the features and the number of cases are recorded here. When multiple operations are tested, multiple tables are needed to include details of these operations.

Operation:

Test Point Description Quantity Comment
Data type test half/float/int8 pass
Mult-tensor test Supports 1-8 dims pass
Layout test Supports NCHW/NHWC none
Zero element test Whether to support this test none
Stability test --gtest_repeat=NUM
--thread=NUM
pass
mlu-only mode test --mlu-only,see MLU-OPS Performance Acceptance Standard none
Mult-platform test MLU370/MLU590 pass
Nan/INF test Whether to support this test pass
Memory leak check Test result pass
Code coverage check Test result none

@PetrelYy PetrelYy added this to the 0.7.1 milestone Jun 7, 2023
@PetrelYy PetrelYy force-pushed the fix_mem_leaks branch 2 times, most recently from 05279ce to e3a7207 Compare June 7, 2023 09:03
@PetrelYy PetrelYy added the BANGC label Jun 7, 2023
@PetrelYy PetrelYy removed this from the 0.7.1 milestone Jun 7, 2023
@PetrelYy PetrelYy changed the title [Feature](bangc-ops): fix memory leak [Fix](bangc-ops): fix memory leak Jun 7, 2023
@PetrelYy PetrelYy merged commit 3898ef3 into Cambricon:master Jun 8, 2023
@PetrelYy PetrelYy deleted the fix_mem_leaks branch June 8, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants