Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade PostCSS@7 & Add storybook #12

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Downgrade PostCSS@7 & Add storybook #12

merged 2 commits into from
Jan 29, 2021

Conversation

thenods
Copy link
Member

@thenods thenods commented Jan 29, 2021 •
edited
Loading

Downgrade PostCSS@7 & Add Storybook

Description

  1. Downgrade PostCSS to v7
  2. Support tailwindCSS to use PostCSS@7
  3. Storybook initialize

Motivation and Context

  1. https://tailwindcss.com/docs/installation#post-css-7-compatibility-build
  2. Storybook doesn't work with the newest version 10.0.1 of PostCSS Autoprefixer plugin storybookjs/storybook#12668 (comment)
  3. https://storybook.js.org/docs/react/get-started/install

How Has This Been Tested?

  1. Create a component and a story in the declared path(inside .storybook/main.js)
  2. yarn storybook

Screenshots (if appropriate):

image

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.

@thenods thenods self-assigned this Jan 29, 2021
@thenods thenods requested a review from WDever January 29, 2021 14:40
@thenods thenods added the enhancement New feature or request label Jan 29, 2021
@thenods thenods changed the title Add storybook Downgrade PostCSS@7 & Add storybook Jan 29, 2021
@thenods thenods marked this pull request as ready for review January 29, 2021 14:48
WDever
WDever approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@WDever WDever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thenods thenods merged commit 2cede42 into COVID-19-VACINE-COVAST:main Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WDever WDever WDever approved these changes

Assignees

@thenods thenods

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thenods @WDever