Reapply netlink retries #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaritarodrigues
requested changes
Dec 28, 2023
The stack sends three requests to the kernel using the netlink socket. If the kernel is e.g. busy at this point, netlink will respond with a EBUSY error value. The current code does not handle these errors gracefully, but instead silently ignores them. This can lead to vsomeip stack being stalled, and not starting certain services, e.g. service discovery. This patch helps fix these issues by sending a retry of the messages that fail.
hefroy
force-pushed
the
reapply-netlink-retries
branch
from
6342a57
to
e4d1a01
Compare
anaritarodrigues
requested changes
Jan 18, 2024
Only log error after retries exhausted and fix error message output, as strerror takes positive errno.
hefroy
force-pushed
the
reapply-netlink-retries
branch
from
e4d1a01
to
8e7896e
Compare
Applied ✔️ |
anaritarodrigues
approved these changes
Jan 19, 2024
milancpp
pushed a commit
to ApexAI/vsomeip
that referenced
this pull request
Apr 26, 2024
* Retry failed netlink operations The stack sends three requests to the kernel using the netlink socket. If the kernel is e.g. busy at this point, netlink will respond with a EBUSY error value. The current code does not handle these errors gracefully, but instead silently ignores them. This can lead to vsomeip stack being stalled, and not starting certain services, e.g. service discovery. This patch helps fix these issues by sending a retry of the messages that fail. * Limit netlink retries to 3, improve error logging Only log error after retries exhausted and fix error message output, as strerror takes positive errno. --------- Co-authored-by: Philip Werner <phiwer@gmail.com>
This was referenced Apr 26, 2024
milancpp
added a commit
to ApexAI/vsomeip
that referenced
this pull request
Apr 26, 2024
Cherry-pick: Reapply netlink retries (COVESA#591)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapplying commit a268e2d from @phiwer with #283 which was removed by commit 826ebb8 from @DiogoPedrozza.
Additionally:
strerrortakes a positiveerrno.